Use MemoryAllocator in FixedCapacityPooledMemoryStream #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1223 +/- ##
==========================================
+ Coverage 82.40% 82.54% +0.14%
==========================================
Files 696 697 +1
Lines 30553 30506 -47
Branches 3482 3467 -15
==========================================
+ Hits 25176 25181 +5
+ Misses 4658 4606 -52
Partials 719 719
Continue to review full report at Codecov.
|
JimBobSquarePants
deleted the
af/FixedCapacityPooledMemoryStream-use-allocator
branch
4 tasks
This was referenced Jul 30, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Integrating
FixedCapacityPooledMemoryStreamwithMemoryAllocatorand moving duplicate async decoder code to a utility class.ArrayPool.Sharedis good when (1) the rented buffer is relatively small (2) theRentoperation is a bottleneck on a hot path. In image processing these conditions are barely true. For a byte array> 1MB, the shared pool is always allocating a new array, which is a common for raw image streams.